Changes between Initial Version and Version 1 of Ticket #3898, comment 6


Ignore:
Timestamp:
Nov 2, 2020, 6:29:33 PM (5 years ago)
Author:
Tom Goddard

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #3898, comment 6

    initial v1  
    11This seems like an error prone solution.  It is too easy to forget to put this tag in their bunde_info.py.  The bundle lists the requirements such as ChimeraX-Core ~= 1.0 and does not list any Python requirement so I think for pure Python bundles the best assumption is that the code only needs the Python included in ChimeraX core 1.0 or newer.  So "devel build" should not add a Python >= 3.8 dependency.
    22
    3 If the above is not feasible, then the Toolshed upload needs to not offer to install a bundle that says it requires ChimeraX-Core ~= 1.0 if it also says it requires Python >= 3.8 since ChimeraX 1.0 uses Python 3.7.  As it is now ChimeraX attempts to install it and it fails in a cryptic way.  Just not offering to install it is also likely to be very confusing.  So in fact, probably Toolshed needs to not let you upload a bundle that claims ChimeraX 1.0 compatibility and also requires Python 3.8.  These checks seem hard to implement which brings me back to thinking that the devel command should not have put the Python >= 3.8 requirement into the wheel in the first place if the user did not explicitly specify that requirement in bundle_info.xml.
     3If the above is not feasible, then the Toolshed needs to not offer to install a bundle that says it requires ChimeraX-Core ~= 1.0 if it also says it requires Python >= 3.8 since ChimeraX 1.0 uses Python 3.7.  As it is now ChimeraX attempts to install it and it fails in a cryptic way.  Just not offering to install it is also likely to be very confusing.  So in fact, probably Toolshed needs to not let you upload a bundle that claims ChimeraX 1.0 compatibility and also requires Python 3.8.  These checks seem hard to implement which brings me back to thinking that the devel command should not have put the Python >= 3.8 requirement into the wheel in the first place if the user did not explicitly specify that requirement in bundle_info.xml.