Changes between Initial Version and Version 1 of Ticket #5137, comment 2


Ignore:
Timestamp:
Sep 1, 2021, 12:37:17 AM (4 years ago)
Author:
Zach Pearson

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #5137, comment 2

    initial v1  
    33I think the main reason for the wonky spacing is that the Graphics -> Background section is the tallest thing in the toolbar and sets the height of all the other sections too. It also looks like instead of shrinking overall the whole thing just expanded to fit the new space.
    44
    5 Anyway as for fixes -- besides reverting the commit, setting the height of QTabWidgets to a fixed 102px and adding a 4px bottom margin to QLabels made the spacing even slightly closer than before (and the 4 pixel offset looks better imo). The main thing I dislike about this fix is that the tab bar is resizable but setting a fixed height on the child widget means it won't grow with the tab bar. What's frustrating is that after many iterations, I haven't yet found the correct incantation of padding-margin-spacing-border pixel values to get the same behavior that I know is possible from seeing the buttons scrunched together by the 102px fixed height. But when I try to fix the borders, Qt wants to cut labels off instead of bringing things closer together!
     5Anyway as for fixes -- besides reverting the commit, setting the height of QTabWidgets to a fixed 102px and adding a 4px bottom margin to QLabels made the spacing even slightly closer than before (and the 4 pixel offset looks better imo). The main thing I dislike about this fix is that the tab bar is resizable but setting a fixed height on the child widget means it won't grow with the tab bar. What's frustrating is that after many iterations, I haven't yet found the correct incantation of padding-margin-spacing-border pixel values to get the same behavior that I know is possible from seeing the buttons spacing condensed by the 102px fixed height. But when I try to fix the borders, Qt wants to cut labels off instead of bringing things closer together!
    66
    77It may be fair to say that commit was premature.