Changes between Initial Version and Version 1 of Ticket #8825, comment 2


Ignore:
Timestamp:
May 16, 2023, 1:43:42 PM (3 years ago)
Author:
Tom Goddard

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #8825, comment 2

    initial v1  
    11It appears the user changed the 2d label model number from an integer to be under another model so its id became #5.3.  The log shows they used the "rename" command to change many id numbers.  The problem is that overlay models such as 2d labels are not part of the 3D scene Drawing hierarchy.  Instead they are part of their own hierarchy for overlays which is only 1 level deep.  This is because those overlays are not located in 3 dimensions.  They don't use the position transform hierarchy (in fact don't use the position transform at all when rendering since they render in screen rectangle coordinates).  Putting an overlay model in the 3D hierarchy is likely to cause chaos.  The code requires that model #5.3 have model #5 as a parent.  But if #5.3 is an overlay it cannot have a parent in the 3D scene.  Conversely an overlay cannot have child models from the 3D scene.
    22
    3 So I think the solution to this bug is that the rename command should not allow changing the id of an overlay to be anything but an integer, and also rename cannot make any model a child of an overlay.   The rule is that 2D models are not part oa hierarchy.  This is a bit annoying.  Eric points out that it is pretty reasonable to want to put a 2D overlay that labels a specific structure as a child of that structure so that deleting or hiding the structure deletes or hides the label.
     3So I think the solution to this bug is that the rename command should not allow changing the id of an overlay to be anything but an integer, and also rename cannot make any model a child of an overlay.   The rule is that 2D models are not part of a hierarchy.  This is a bit annoying.  Eric points out that it is pretty reasonable to want to put a 2D overlay that labels a specific structure as a child of that structure so that deleting or hiding the structure deletes or hides the label.
    44
    55It might be possible to allow overlays to be in any hierarchy.  But it is perhaps confusing that they are not effected by their parent's transform.  And this would likely involve the model id numbers not having the same hierarchy as the Drawing parent / child relations which is a complication.