Changes between Initial Version and Version 1 of Ticket #8832, comment 2


Ignore:
Timestamp:
Apr 14, 2023, 4:56:24 PM (3 years ago)
Author:
Eric Pettersen

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #8832, comment 2

    initial v1  
    1 To properly set StructureData.display (so that 'display changed' gets into atomic triggers) Structure was listening to MODEL_DISPLAY_CHANGED (so as not to obscure Model.display with its own 'display' attribute.  This is N-squared in the number of models if all models are being hidden/shown.  So I eliminated that trigger handler and _do_ override 'display', but the overriding method calls Model.diaplsy _and_ StructureData.display.
     1To properly set !StructureData.display (so that 'display changed' gets into atomic triggers) Structure was listening to MODEL_DISPLAY_CHANGED (so as not to obscure Model.display with its own 'display' attribute).  This is N-squared in the number of models if all models are being hidden/shown.  So I eliminated that trigger handler and _do_ override 'display', but the overriding method calls Model.diaplsy _and_ !StructureData.display.
    22
    33https://github.com/RBVI/ChimeraX/commit/f45cf2b229f1b5671ab766f56714487992ce816b