"Report a bug" should not be an option for errors that derive from NotABug

[Eric Pettersen]

As summary. Pretty much the point of those error types (UserError, LimitationError, etc.)

Errors of this type caused from a typed command are already caught by the command line (well, UserError at least) and don't generate a dialog at all. Errors from other sources are the problem.

[Tom Goddard]

I never saw a UserError or LimitationError that showed an error dialog. Can you give an example where that occurs?

The error dialog is handled by the log bundle and is shown when an error is logged. The log has no idea what kind of exception was raised, only the code which logged the error knows that. So if we need the error dialog to show or hide the bug report button then the logger interface will need to be able to convey that additional information.

[Eric Pettersen]

Here's two ways to do it. Open the attached file and UserError is raised and results in a dialog with Report Bug. The second way is to drag out a toolbar so that it is floating, then right click on it to get a context menu and choose "Save tool position". This raises Limitation Error and also produces a Report Bug dialog. You need a quasi-recent checkout for the latter behavior.

[Tom Goddard]

Ok. I'm interested in real cases that produce undesired report-a-bug buttons. I'm wondering if it ever really happens that you want to raise an error dialog when it isn't an error. Maybe. But then maybe Logger should have another category besides error, warning, info, that instead indicates this is and important message that is not a reportable error.

Reassigning to Eric to evaluate how and whether the Logger API should change to support non-reportable errors.

[Eric Pettersen]

Made an additional log level: LEVEL_BUG. Only this level puts the 'Report Bug' button on the dialog.