Opened 7 years ago

Closed 7 years ago

#1677 closed defect (fixed)

Logged commands are missing required quotation marks

Reported by: goddard@… Owned by: Greg Couch
Priority: normal Milestone:
Component: Command Line Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

The following bug report has been submitted:
Platform:        Darwin-17.7.0-x86_64-i386-64bit
ChimeraX Version: 0.9 (2019-01-31)
Description
Logged commands eliminate quotation marks from arguments making the logged version not execute correctly.  The quotation marks need to be preserved in the logged version.

Specifically the command finished trigger provides a version of the following command

volume #1 appear "Airways II"

that looks like

volume #1 appearance Airways II

that has stripped out the quotation marks and running it without the quotation marks is an error.  This causes a two person VR session to fail to run the mirrored command on the remote computer.

Log:
UCSF ChimeraX version: 0.9 (2019-01-31)  
© 2016-2019 Regents of the University of California. All rights reserved.  
How to cite UCSF ChimeraX  
running command 'vol #1 appear "Airways II"'  

> volume #1 appearance Airways II

got command 'volume #1 appearance Airways II'  
No volumes specified  




OpenGL version: 4.1 NVIDIA-10.32.0 355.11.10.10.40.102
OpenGL renderer: NVIDIA GeForce GTX 680MX OpenGL Engine
OpenGL vendor: NVIDIA Corporation

Change History (2)

comment:1 by Tom Goddard, 7 years ago

Component: UnassignedCommand Line
Owner: set to Greg Couch
Platform: all
Project: ChimeraX
Status: newassigned
Summary: ChimeraX bug report submissionLogged commands are missing required quotation marks

comment:2 by Greg Couch, 7 years ago

Resolution: fixed
Status: assignedclosed

Fixed.

This needs to be handled on a per-annotation basis, since annotations can be nested. In an annotation's parse method, the second item in the returned tuple is the text to display. A simple fix is to call quote_if_necessary on its value.

Note: See TracTickets for help on using tickets.