Opened 3 weeks ago

Closed 8 days ago

#19375 closed defect (fixed)

Animations not calling interpolate_scene

Reported by: Eric Pettersen Owned by: Zach Pearson
Priority: moderate Milestone:
Component: Depiction Version:
Keywords: Cc: Elaine Meng
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

In the current daily build, the Animations tool is not calling interpolate_scene on Structure models. I have attached a session with three scenes. If I put the three scenes on the Animations timeline, the atom radii do not interpolate, they just switch over when the scene changes. It I put a print statement at the start of Structure's interpolate_scene method, nothing is printed in the log.

Attachments (1)

simple.cxs​ (18.0 KB ) - added by Eric Pettersen 3 weeks ago.
3 scenes

Download all attachments as: .zip

Change History (2)

by Eric Pettersen, 3 weeks ago

Attachment: simple.cxs​ added

3 scenes

comment:1 by Eric Pettersen, 8 days ago

Resolution: → fixed
Status: assigned → closed

Some over-aggressive optimizations you had in the scene manager's interpolate_scenes() method skipped calling the structure's interpolate_scene when it shouldn't have.

Fix: ​https://github.com/RBVI/ChimeraX/commit/ec8e90f42f4073a9c42d73d0a13113bcf635a5ac

Note: See TracTickets for help on using tickets.